Messages in this thread | | | Subject | Re: connector.h | From | Evgeniy Polyakov <> | Date | Fri, 01 Apr 2005 11:09:54 +0400 |
| |
On Thu, 2005-03-31 at 17:31 -0800, Andrew Morton wrote: > > > > struct cb_id > > { > > __u32 idx; > > __u32 val; > > }; > > It is vital that all data structures be skilfully commented - they are the > key to understanding the code. Why the struct exists, which actor passes > it to which other actor(s), whether the data structure is communicated with > userspace, what other data structures it is aggregated with or linked to, > locking rules, etc.
It is described in Documentation/connector/connector.txt. Should it also be placed here?
> > struct cn_msg > > { > > Please do > > struct cn_msg {
Neither structure declaration should have opening brace on the new string?
> > > > #define CN_CBQ_NAMELEN 32 > > Commentary?
Maximum allowed callback name - name will be truncated if it exceeds that limit.
I will place this doc in the code.
-- Evgeniy Polyakov
Crash is better than data corruption -- Arthur Grabowski [unhandled content-type:application/pgp-signature] | |