Messages in this thread | | | Date | Wed, 9 Mar 2005 21:25:07 -0600 | Subject | Re: [PATCH 2/2] No-exec support for ppc64 | From | (Olof Johansson) |
| |
Hi,
On Tue, Mar 08, 2005 at 05:13:26PM -0600, Jake Moilanen wrote: > diff -puN arch/ppc64/mm/hash_utils.c~nx-kernel-ppc64 arch/ppc64/mm/hash_utils.c > --- linux-2.6-bk/arch/ppc64/mm/hash_utils.c~nx-kernel-ppc64 2005-03-08 16:08:57 -06:00 > +++ linux-2.6-bk-moilanen/arch/ppc64/mm/hash_utils.c 2005-03-08 16:08:57 -06:00 > @@ -89,12 +90,23 @@ static inline void loop_forever(void) > ; > } > > +int is_kernel_text(unsigned long addr) > +{ > + if (addr >= (unsigned long)_stext && addr < (unsigned long)__init_end) > + return 1; > + > + return 0; > +}
This is used in two files, but never declared extern in the second file (iSeries_setup.c). Should it go in a header file as a static inline instead?
There also seems to be a local static is_kernel_text() in kallsyms that overlaps (but it's not identical). Removing that redundancy can be taken care of as a janitorial patch outside of the noexec stuff.
-Olof - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |