Messages in this thread | | | Subject | Re: [PATCH] make st seekable again | From | Alan Cox <> | Date | Wed, 09 Mar 2005 20:51:15 +0000 |
| |
On Maw, 2005-03-08 at 17:25, Linux Kernel Mailing List wrote: > ChangeSet 1.2030, 2005/03/08 09:25:05-08:00, kai.makisara@kolumbus.fi > > [PATCH] make st seekable again > > Apparently `tar' errors out if it cannot perform lseek() against a tape. Work > around that in-kernel.
Unfortunately this isn't a good idea. Allowing tar to read the tape position makes sense, allowing it to zero the position might but you have to do major surgery on the driver first because
1. It doesn't use ppos 2. It doesn't do locking on the ppos at all
Also allowing apps to randomly seek and report "ok" when they are backing up to tape and might really need to see the error is not what I'd call stable, professional or quality code.
I oppose this change for 2.6.11.3, I think 2.6.12 needs to address the rest of the mess in that code to make it work (or implement a 'read only' llseek and use ppos right)
And -ac won't carry this change.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |