lkml.org 
[lkml]   [2005]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.11-mm1: sound <-> GAMEPORT problems
    On Mon, 7 Mar 2005 22:52:06 +0100, Adrian Bunk <bunk@stusta.de> wrote:
    > On Mon, Mar 07, 2005 at 09:41:59AM +0100, Borislav Petkov wrote:
    > > On Friday 04 March 2005 12:32, Andrew Morton wrote:
    > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11/2.6.11
    > > >-mm1/
    > > >
    > > <snip>
    > >
    > > Hi,
    > >
    > > the ymfpci sound driver wouldn't compile without gameport support selected
    > > since the sound card has a gameport on it:
    > >
    > > Signed-off-by: Borislav Petkov <petkov@uni-muenster.de>
    > >
    > > --- sound/pci/ymfpci/ymfpci.c.orig 2005-03-07 09:07:10.000000000 +0100
    > > +++ sound/pci/ymfpci/ymfpci.c 2005-03-07 09:08:02.000000000 +0100
    > > @@ -332,7 +332,9 @@ static int __devinit snd_card_ymfpci_pro
    > > }
    > > }
    > >
    > > +#ifdef SUPPORT_JOYSTICK
    > > snd_ymfpci_create_gameport(chip, dev, legacy_ctrl, legacy_ctrl2);
    > > +#endif /* SUPPORT_JOYSTICK */
    > >
    > > if ((err = snd_card_register(card)) < 0) {
    > > snd_card_free(card);
    >
    > Nice catch (but I had to apply the patch manually due to some
    > whitespace damage).
    >
    > After a quick look, it seems there are a dozen other sound drivers (most
    > OSS but also ALSA) with similar problems.

    Note that in input tree (and in -mm) I tried to clean up these #ifdefs
    by providing dummy functions when CONFIG_GAMEPORT is not selected. The
    original report caused by the typo in dummy function name
    (snc_ymfpci_create_gameport).

    --
    Dmitry
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:10    [W:0.023 / U:64.312 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site