Messages in this thread | | | Date | Sat, 5 Mar 2005 21:56:35 -0800 | From | Greg KH <> | Subject | Re: [PATCH 1/13] speedtch: Clean up printk()'s in drivers/usb/atm/speedtch.c |
| |
On Sat, Mar 05, 2005 at 05:37:13PM -0600, James Nelson wrote: > Add a KERN_WARNING constant to a printk() that is missing it, and add a driver > prefix to another two in drivers/usb/atm/speedtch.c
Please CC: usb patches to the usb maintainer, it makes it a bit hard for him to apply them otherwise :)
> Signed-off-by: James Nelson <james4765@gmail.com> > > diff -Nurp -x dontdiff-osdl --exclude='*~' linux-2.6.11-mm1-original/drivers/usb/atm/speedtch.c linux-2.6.11-mm1/drivers/usb/atm/speedtch.c > --- linux-2.6.11-mm1-original/drivers/usb/atm/speedtch.c 2005-03-05 13:29:48.000000000 -0500 > +++ linux-2.6.11-mm1/drivers/usb/atm/speedtch.c 2005-03-05 13:36:44.000000000 -0500 > @@ -192,8 +192,8 @@ static int speedtch_set_swbuff(struct sp > 0x32, 0x40, state ? 0x01 : 0x00, > 0x00, NULL, 0, 100); > if (ret < 0) { > - printk("Warning: %sabling SW buffering: usb_control_msg returned %d\n", > - state ? "En" : "Dis", ret); > + printk(KERN_WARNING "%s: %sabling SW buffering: usb_control_msg returned %d\n", > + speedtch_driver_name, state ? "En" : "Dis", ret);
No, please, if you are going to convert anything like this, use the dev_dbg(), dev_warn(), and assorted macros instead. Or if nothing else, the usb subsystem has it's own dbg(), err() and warn() macros that should be gotten rid of, but that's a lot of changes...
These comments pretty much go for all of your patches in this series, please rework them all.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |