lkml.org 
[lkml]   [2005]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] add scsi changer driver
From
Date
Looking through this, the only things I really noticed that need work
are:

ch_do_scsi(): It looks like this has an effective reimplementation of
scsi_wait_req. We're trying to deprecate the usage of scsi_do_req so we
can make it private eventually. What's the reason you can't use
scsi_wait_req?

ch_ioctl() (and the compat): since this is a new driver, can't this all
be done via sysfs? That way, the user would be able to manipulate it
from the command line, and we'd no longer need any of the 32->64 compat
glue.

James



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:10    [W:0.071 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site