Messages in this thread | | | Subject | Re: [patch 1/8] isdn_bsdcomp.c - vfree() checking cleanups | Date | Mon, 07 Mar 2005 00:07:48 +0000 | From | Ralph Corderoy <> |
| |
Hi Domen,
> - if (db->dict) { > - vfree (db->dict); > - db->dict = NULL; > - } > + vfree (db->dict); > + db->dict = NULL;
Is it really worth always calling vfree() which calls __vunmap() before db->dict is determined to be NULL in order to turn three lines into two? Plus the write to db->dict which might otherwise not be needed. The old code was clear, clean, and fast, no?
Cheers,
Ralph.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |