Messages in this thread |  | | | Date | Sat, 5 Mar 2005 00:35:02 +0100 | | From | Andries Brouwer <> | | Subject | Re: Linux 2.6.11.1 |
| |
On Fri, Mar 04, 2005 at 12:44:31PM -0800, Andrew Morton wrote:
> Here's the list of things which we might choose to put into 2.6.11.2. ... > nfsd--exportfs-reduce-stack-usage.patch ...
Different people want different things with our 2.6.x.y. I would hope that criteria include (i) patch is obvious, and (ii) patch fixes an embarrassing flaw.
I see no reason to include random small improvements.
(Always some of these small improvements will be a mistake, so, in .y, when something is not really broken, don't fix it. Maybe people were actually seeing stack overflows here?)
Andries
>> From: NeilBrown <neilb@cse.unsw.edu.au> >> >> find_exported_dentry() declares >> char nbuf[NAME_MAX+1]; >> in 2 separate places, and gcc allocates space on the stack for both >> of them. Having just one of them will suffice, if we can put put >> with its scope. >> >> Reduces function stack usage on x86-32 from 0x230 to 0x130.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |