lkml.org 
[lkml]   [2005]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] unexport complete_all
On Fri, Mar 04, 2005 at 03:09:39AM -0500, Mike Waychison wrote:
> > I didn't find any possible modular usage in the kernel.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >
> > --- linux-2.6.11-rc5-mm1-full/kernel/sched.c.old 2005-03-04 01:04:28.000000000 +0100
> > +++ linux-2.6.11-rc5-mm1-full/kernel/sched.c 2005-03-04 01:04:34.000000000 +0100
> > @@ -3053,7 +3053,6 @@
> > 0, 0, NULL);
> > spin_unlock_irqrestore(&x->wait.lock, flags);
> > }
> > -EXPORT_SYMBOL(complete_all);
> >
> > void fastcall __sched wait_for_completion(struct completion *x)
> > {
> > -
>
> This is a valid piece of API that is exported for future use.
>...

You exported this function nearly one year ago with the only comment
"Export complete_all for module use.".

Why did you add the export last year instead of simply adding it when it
will be required?

> Mike Waychison

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:10    [from the cache]
©2003-2011 Jasper Spaans