lkml.org 
[lkml]   [2005]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] I2C: Fix race condition in it87 driver
    Date
    From
    ChangeSet 1.2345, 2005/03/31 14:31:21-08:00, khali@linux-fr.org

    [PATCH] I2C: Fix race condition in it87 driver

    I noticed a race condition in the it87, affecting the IT8712F chip only.
    The VRM value is currently initialized *after* creating the vrm and vid
    sysfs files. This leaves a theorical room for reading from these files
    and get an invalid value. It's not critical, but let's still fix it.

    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>


    drivers/i2c/chips/it87.c | 2 +-
    1 files changed, 1 insertion(+), 1 deletion(-)


    diff -Nru a/drivers/i2c/chips/it87.c b/drivers/i2c/chips/it87.c
    --- a/drivers/i2c/chips/it87.c 2005-03-31 15:16:31 -08:00
    +++ b/drivers/i2c/chips/it87.c 2005-03-31 15:16:31 -08:00
    @@ -889,9 +889,9 @@
    }

    if (data->type == it8712) {
    + data->vrm = i2c_which_vrm();
    device_create_file_vrm(new_client);
    device_create_file_vid(new_client);
    - data->vrm = i2c_which_vrm();
    }

    return 0;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-04-06 13:31    [W:0.021 / U:31.516 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site