lkml.org 
[lkml]   [2005]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/
    On Sun, 27 Mar 2005 12:40:26 -0500, Dave Jones <davej@redhat.com> wrote:
    > Am I the only person who is completely fascinated by the
    > effort being spent here micro-optimising something thats
    > almost never in a path that needs optimising ?
    > I'd be amazed if any of this masturbation showed the tiniest
    > blip on a real workload, or even on a benchmark other than
    > one crafted specifically to test kfree in a loop.

    Indeed. The NULL checks are redundant and thus need to go. If someone
    can show a measurable performance regression in the kernel for a
    realistic workload, kfree() can be turned into an inline function
    which will take care of it. The microbenchmarks are fun but should not
    stand in the way of merging the kfree() cleanups from Jesper and
    others.

    Pekka
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-04-06 13:31    [W:3.004 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site