Messages in this thread Patch in this message | | | From | Rolf Eike Beer <> | Subject | Re: PCI: remove pci_find_device usage from pci sysfs code. | Date | Thu, 24 Mar 2005 22:06:11 +0100 |
| |
Greg KH wrote: > On Sun, Mar 20, 2005 at 03:53:58PM +0100, Rolf Eike Beer wrote: > > Greg KH wrote: > > > ChangeSet 1.1998.11.23, 2005/02/25 08:26:11-08:00, gregkh@suse.de > > > > > > PCI: remove pci_find_device usage from pci sysfs code.
> > Any reasons why you are not using "for_each_pci_dev(pdev)" here? > > Nope, I forgot it was there :)
Patch is against 2.6.12-rc1-bk1 and does the same think like your one, except it uses for_each_pci_dev()
Eike
Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
--- linux-2.6.11/drivers/pci/pci-sysfs.c 2005-03-21 11:41:56.000000000 +0100 +++ linux-2.6.12-rc1/drivers/pci/pci-sysfs.c 2005-03-24 19:20:50.000000000 +0100 @@ -481,7 +481,7 @@ static int __init pci_sysfs_init(void) struct pci_dev *pdev = NULL; sysfs_initialized = 1; - while ((pdev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, pdev)) != NULL) + for_each_pci_dev(pdev) pci_create_sysfs_dev_files(pdev); return 0; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |