Messages in this thread | | | Date | Fri, 25 Mar 2005 16:42:37 +0100 | From | Pavel Machek <> | Subject | Re: swsusp 'disk' fails in bk-current - intel_agp at fault? |
| |
Hi!
> > > This is more of a general swsusp problem I believe - the second phase > > > when it blindly resumes entire system. Resume of a device can fail > > > (any reason whatsoever) and it will attempt to clean up after itself, > > > but userspace is dead and hotplug never completes. While I am > > > interested to know why ALPS does not want to resume on ANdy's laptop > > > the issue will never be completely resolved from within the input > > > system. > > > > When device fails to resume, what should I do? I think I could > > > > if (error) > > panic("Device resume failed\n"); > > > > , but... that does not look like what you want. > > Oh, always panic-happy Pavel ;). It really depends on what kind of > device has faled to resume. If the device is really needed for writing > image then panic is the only recourse, but if it some other device you > resuming just ignore it, who cares...
You are right, for resume-during-suspend, we may as well risk it. We have consistent state, and if we happen to write it on disk, everything is okay.
For resume-during-resume, I don't really know how we can handle that. Running with some devices non-working seems dangerous to me.
> Btw, I dont think that doing selective resume (as opposed to selective > suspend and Nigel's partial device trees) would be so much > complicated. You'd always resume sysdevs and then, when iterating over > "normal" devices, just skip ones not in resume path. It can all be > contained in driver core I believe (sorry but no patch, for now at > least).
:-) I think we can simply make device freeze/unfreeze fast enough. [We do not need to do full suspend/resume; freeze is enough].
Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |