lkml.org 
[lkml]   [2005]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] drivers/net/tulip/dmfe.c: fix check after use
Adrian Bunk wrote:
> This patch fixes a check after use found by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.12-rc1-mm1-full/drivers/net/tulip/dmfe.c.old 2005-03-23 05:05:36.000000000 +0100
> +++ linux-2.6.12-rc1-mm1-full/drivers/net/tulip/dmfe.c 2005-03-23 05:06:00.000000000 +0100
> @@ -736,20 +736,22 @@
>
> static irqreturn_t dmfe_interrupt(int irq, void *dev_id, struct pt_regs *regs)
> {
> struct DEVICE *dev = dev_id;
> struct dmfe_board_info *db = netdev_priv(dev);
> - unsigned long ioaddr = dev->base_addr;
> + unsigned long ioaddr;
> unsigned long flags;
>
> DMFE_DBUG(0, "dmfe_interrupt()", 0);
>
> if (!dev) {
> DMFE_DBUG(1, "dmfe_interrupt() without DEVICE arg", 0);
> return IRQ_NONE;
> }

I would prefer to remove the "if (!dev)" test, since it shouldn't ever
succeed.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-06 13:30    [W:0.299 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site