[lkml]   [2005]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] I2C Part 1 - Remove some redundancy from the i2c-core.c file
    Hi Corey,

    > Call i2c_transfer() from i2c_master_send() and i2c_master_recv()
    > to avoid the redundant code that was in all three functions.

    I like this. You're right, there is code duplication here, which we can
    get rid of, so let's do so. I'd only have one comments about your patch:

    You can get rid of the dev_dbg calls in i2c_master_send() and
    i2c_master_recv() altogether IMHO. I recently updated i2c_transfer() to
    make it more verbose in debug mode [1], so the debug messages in
    i2c_master_send() and i2c_master_recv() are mostly redundant now as far
    as I can see.


    Jean Delvare
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-04-06 13:30    [W:0.019 / U:2.112 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site