Messages in this thread | | | Subject | Re: [PATCH scsi-misc-2.6 01/08] scsi: remove unused bounce-buffer release path | From | James Bottomley <> | Date | Tue, 22 Mar 2005 22:07:26 -0600 |
| |
On Wed, 2005-03-23 at 11:14 +0900, Tejun Heo wrote: > 01_scsi_remove_scsi_release_buffers.patch > > Buffer bouncing hasn't been done inside the scsi midlayer for > quite sometime now, but bounce-buffer release paths are still > around. This patch removes these unused paths.
Yes, but scsi_release_buffers isn't referring to bounce buffers anymore, it's simply releasing the sg buffers.
[...] > - else if (cmd->buffer != req->buffer) { > - if (rq_data_dir(req) == READ) { > - unsigned long flags; > - char *to = bio_kmap_irq(req->bio, &flags); > - memcpy(to, cmd->buffer, cmd->bufflen); > - bio_kunmap_irq(to, &flags); > - } > - kfree(cmd->buffer); > - }
I'll defer to Jens here, but I don't thing you can just remove this ... sg_io with a misaligned buffer will fail without this.
That rather nasty code freeing cmd->buffer needs to be in there as well ... so it does make sense to keep this API
James
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |