lkml.org 
[lkml]   [2005]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects
    Andrew Morton wrote:
    > Jeff Garzik <jgarzik@pobox.com> wrote:
    >
    >>>Thing is, CRYPTO_AES on only selectable on x86.
    >>
    >> You're thinking about CRYPTO_AES_586. But looking at crypto/Kconfig,
    >> the dependencies are a bit weird:
    >>
    >> config CRYPTO_AES
    >> tristate "AES cipher algorithms"
    >> depends on CRYPTO && !(X86 && !X86_64)
    >> config CRYPTO_AES_586
    >> tristate "AES cipher algorithms (i586)"
    >> depends on CRYPTO && (X86 && !X86_64)
    >
    >
    > That's pretty broken, isn't it?
    >
    > Would be better to just do:
    >
    > config CRYPTO_AES
    > select CRYPTO_AES_586 if (X86 && !X86_64)
    > select CRYPTO_AES_OTHER if !(X86 && !X86_64)
    >
    > and hide CRYPTO_AES_586 and CRYPTO_AES_OTHER from the outside world.

    Not really that easy. For x86 we have

    aes
    aes-586
    aes-via

    And my own personal custom-kernel preference is to use the C version of
    the code on my x86 and x86-64 boxes.

    Jeff


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:10    [W:0.022 / U:31.604 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site