lkml.org 
[lkml]   [2005]   [Mar]   [2]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
DateTue, 1 Mar 2005 23:11:47 -0800
FromGreg KH <>
Subject[PATCH] fix module paramater permissions in radeon_base.c
You really don't want -2 for the file mode in sysfs.  It creates:
  -rwsrwsrwT  1 root root 4096 Mar  1 22:59 /sys/module/radeonfb/parameters/default_dynclk

on my box.  Here's a fix against a clean 2.6.11-rc5 kernel, please
forward onward as you see fit.


Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>


--- 1.27/drivers/video/aty/radeon_base.c	2005-02-24 11:40:00 -08:00
+++ edited/drivers/video/aty/radeon_base.c	2005-03-01 23:09:12 -08:00
@@ -2551,7 +2551,7 @@
 MODULE_DESCRIPTION("framebuffer driver for ATI Radeon chipset");
 MODULE_LICENSE("GPL");
 module_param(noaccel, bool, 0);
-module_param(default_dynclk, int, -2);
+module_param(default_dynclk, int, 0);
 MODULE_PARM_DESC(default_dynclk, "int: -2=enable on mobility only,-1=do not change,0=off,1=on");
 MODULE_PARM_DESC(noaccel, "bool: disable acceleration");
 module_param(nomodeset, bool, 0);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 14:10    [from the cache]
©2003-2008