Messages in this thread | | | Date | Sat, 19 Mar 2005 00:44:40 +0100 | From | Pavel Machek <> | Subject | Re: fix-u32-vs-pm_message_t-in-usb |
| |
On Pá 18-03-05 13:43:36, Greg KH wrote: > On Fri, Mar 11, 2005 at 02:08:31PM +0100, Pavel Machek wrote: > > Hi! > > > > > This patch has been spitting warnings: > > > > > > drivers/usb/host/uhci-hcd.c:838: warning: initialization from incompatible pointer type > > > drivers/usb/host/ohci-pci.c:191: warning: initialization from incompatible pointer type > > > > > > Because hc_driver.suspend() takes a u32 as its second arg. Changing that > > > to pci_power_t causes build failures and including pci.h in usb.h seems > > > wrong. > > > > > > Wanna fix it sometime? > > > > Yep. Here it is. > > > > This fixes remaining confusion. Part of my old patch was merged, I > > later decided passing pci_power_t down to drivers is bad idea; this > > passes them pm_message_t which contains more info (and actually works > > :-). Please apply, > > Argh, this one is already partially in, and another one you just sent me > has half of it in the tree too... > > Care to just rediff off of 2.6.12-rc1? Then we can hopefully get these > changes in :)
I can do the rediff tommorow. I just hope there are not some other changis waiting in -mm to spoil this ;-). Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |