lkml.org 
[lkml]   [2005]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2/9] Possible AMD8111e free irq issue
Ian Pilcher wrote:
> Chris Wright wrote:
>
>>
>> From: Andres Salomon <dilinger@debian.org>
>>
>> It seems to me that if in the amd8111e_open() fuction dev->irq isn't
>> zero and the irq request succeeds it might not get released anymore.
>>
>
> Based on the wording above, I can't help wondering if this fixes a
> problem that anyone is actually seeing.


Maybe the wording is wrong, but the patch fixes an obvious
leak-on-error. Allocations in amd8111e_init_ring() could certainly fail.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:11    [W:0.084 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site