lkml.org 
[lkml]   [2005]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] ia64 kernel fails to link because of PCI MSI quirk
James Bottomley <James.Bottomley@SteelEye.com> wrote:
>
> The problem is that the MSI code has an unconditional dependency on
> pci_msi_quirk. However, the quirk and the variable are only defined if
> CONFIG_X86_IO_APIC is defined, which it never is on ia64.

Yes, I hit that as well.

> The solution is to make the variable global and unconditional.

I fixed it differently:

--- 25/drivers/pci/pci.h~ia64-msi-build-fix Sat Mar 12 18:13:37 2005
+++ 25-akpm/drivers/pci/pci.h Sat Mar 12 18:14:23 2005
@@ -64,8 +64,13 @@ extern void pci_remove_legacy_files(stru
/* Lock for read/write access to pci device and bus lists */
extern spinlock_t pci_bus_lock;

-extern int pcie_mch_quirk;
+#ifdef CONFIG_X86_IO_APIC
extern int pci_msi_quirk;
+#else
+#define pci_msi_quirk 0
+#endif
+
+extern int pcie_mch_quirk;
extern struct device_attribute pci_dev_attrs[];
extern struct class_device_attribute class_device_attr_cpuaffinity;

_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:11    [W:0.470 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site