lkml.org 
[lkml]   [2005]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [swsusp/ppc] Re: What's going on here ?
    On Tue, Mar 15, 2005 at 01:19:46PM +1100, Benjamin Herrenschmidt wrote:
    >
    > > rjw and hugang did (pretty neccessary) changes to base swsusp (pagedir
    > > table -> pagedir linklist), that unfortunately needed update to all
    > > the assembly parts. It was series 1/3 update core, i386 and x86-64,
    > > 2/3 update ppc, 3/3 introduce initramfs.
    > >
    > > This is the offending patch I believe (but the version that was merged
    > > was From: me, without code changes).
    > >
    > > I realized that patch does more than changing from table to linklist,
    > > but it looked mostly okay, so I forwarded it. Sorry.
    >
    > It does more than that ... it _adds_ swsusp to ppc ! swsusp wasn't in
    > mainline at all for ppc because I consider it not ready. And even the
    > asm change should go through me anyway since i wrote that code and I'm
    > not sure they know all the possible "issues" with that code.
    >
    > > So, what to do now?
    > >
    > > a) just revert it
    > >
    > > or
    > >
    > > b) revert pmac_setup.c and via-pmu parts and Kconfig part
    > >
    > > or
    > >
    > > c) just disable Kconfig part and fix it up with incremental patches

    I hope that's can merge into, It works fine in my PowerBook G4.

    >
    > I'll decide later today. I may well keep it and do the cleanup I had in
    > mind on top of this, which means merging the pmac suspend-to-ram with
    > the common infrastructure. But that will need some changes & hooks to
    > the core swsusp.
    >
    > Ben.


    --
    Hu Gang .-.
    /v\
    // \\
    Linux User /( )\ [204016]
    GPG Key ID ^^-^^ http://soulinfo.com/~hugang/hugang.asc
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:11    [W:0.024 / U:31.656 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site