lkml.org 
[lkml]   [2005]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC][PATCH] new timeofday core subsystem (v. A3)
    From
    Date
    Matt Mackall <mpm@selenic.com> writes:

    > On Fri, Mar 11, 2005 at 05:24:15PM -0800, john stultz wrote:
    >> +struct timesource_t timesource_jiffies = {
    >> + .name = "jiffies",
    >> + .priority = 0, /* lowest priority*/
    >> + .type = TIMESOURCE_FUNCTION,
    >> + .read_fnct = jiffies_read,
    >> + .mask = (cycle_t)~0,
    >
    > Not sure this is right. The type of 0 is 'int' and the ~ will happen
    > before the cast to a potentially longer type.

    If you want an all-one value for any unsigned type then (type)-1 is the
    most reliable way.

    Andreas.

    --
    Andreas Schwab, SuSE Labs, schwab@suse.de
    SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
    Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
    "And now for something completely different."
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:11    [W:0.061 / U:0.196 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site