lkml.org 
[lkml]   [2005]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] realtime-preempt: update inherited priorities on setscheduler

    * Scott Wood <scott@gw.timesys.com> wrote:

    > - p->prio = effective_prio(p);
    > + /* Don't overwrite an inherited RT priority with the static
    > + RT priority. */
    > +
    > + if (!rt_task(p))
    > + p->prio = effective_prio(p);

    are you sure this is needed? The -RT code currently does this:

    static int effective_prio(task_t *p)
    {
    if (rt_task(p))
    return p->prio;
    return __effective_prio(p);
    }

    i.e. if it's an RT task then 'effective priority' is whatever it has
    right now. I.e. 'p->prio = effective_prio(p)' will have no effect for RT
    tasks. PI would not be working at all if we were overwriting the
    inherited priority.

    Ingo
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:11    [W:0.020 / U:32.356 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site