lkml.org 
[lkml]   [2005]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] realtime-preempt: update inherited priorities on setscheduler
From
On Fri, Mar 11, 2005 at 10:36:07AM +0100, Ingo Molnar wrote:
>
> * Scott Wood <scott@gw.timesys.com> wrote:
>
> > - p->prio = effective_prio(p);
> > + /* Don't overwrite an inherited RT priority with the static
> > + RT priority. */
> > +
> > + if (!rt_task(p))
> > + p->prio = effective_prio(p);
>
> are you sure this is needed? The -RT code currently does this:
>
> static int effective_prio(task_t *p)
> {
> if (rt_task(p))
> return p->prio;
> return __effective_prio(p);
> }

I must have read-then-misremembered it as recalculating the prio from
rt_priority, or else been worried about some race that doesn't appear
possible. The change isn't needed.

-Scott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:11    [W:0.075 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site