Messages in this thread | | | Date | Fri, 11 Mar 2005 13:18:36 +1100 | From | Paul Mackerras <> | Subject | Re: AGP bogosities |
| |
Dave Jones writes:
> > cap_ptr = pci_find_capability(device, PCI_CAP_ID_AGP); > > - if (!cap_ptr) { > > - pci_dev_put(device); > > - continue; > > - } > > - cap_ptr = 0; > > } > > This part I'm not so sure about. > The pci_get_class() call a few lines above will get a refcount that > we will now never release.
The point is that pci_get_class does a pci_dev_put() on the "from" parameter, so your code ended up doing a double put.
> Unfortunatly, no-one with ppc64 tested it there it seems :-(
I have only recently got AGP and DRI working on my G5. I'll post a patch for AGP support on the G5 shortly.
Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |