Messages in this thread | | | Date | Thu, 10 Mar 2005 17:30:35 +0100 | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH] ide: hdio.txt update |
| |
Hi,
On Thu, 3 Mar 2005 11:16:38 +0900, Tejun Heo <htejun@gmail.com> wrote:
> + [2] Both the input and output buffers are copied from the > + user and written back to the user, even when not used. The > + out_flags and in_flags are written back to the user after > + the ioctl completes. These are the same as the input > + values, unchanged.
This is incorrect, please refer to flagged_taskfile() and ide_taskfile_ioctl(). Unfortunately you've based your latest patch series on this assumption.
> + Taskfile registers are read back from the drive into > + {io|hob}_ports[] after the command completes iff one of the > + following conditions is met; otherwise, the original values > + will be written back, unchanged. > + > + 1. The drive fails the command (EIO). > + 2. More than one bit is set in tf_out_flags.
Isn't one bit enough?
The rest is of the update is fine, thanks for doing this.
Bartlomiej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |