Messages in this thread | | | Date | Mon, 7 Feb 2005 18:16:46 +0100 | From | Domen Puncer <> | Subject | Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval |
| |
On 07/02/05 07:59 -0800, Randy.Dunlap wrote: > Mikkel Krautz wrote: > >And, here's an updated version of hid-core.c: > > > >Signed-off-by: Mikkel Krautz <krautz@gmail.com> > >--- > >--- clean/drivers/usb/input/hid-core.c > >+++ dirty/drivers/usb/input/hid-core.c ... > >+ > >+static unsigned int hid_mousepoll_interval; > >+module_param_named(mousepoll, hid_mousepoll_interval, uint, 0644); > > Why is it writable by root? IOW, will writing a new value to it > change the operational value dynamically? > > Also, from the kernel-parameters.txt patch: > + usbhid.mousepoll= > + [USBHID] The interval at wich mice are to be polled at. > > (a) "which" > (b) drop one of the "at"s... either one.
Is listing module parameters in kernel-parameters.txt the right thing to do? (There are lots of them, not many are listed)
I see some options that might be better: - Kconfig magic which extracts module_param* and MODULE_PARM_DESC from sources and appends them to help text. - a userspace script, that goes trough all modules and generates kernel-module-parameters.txt for example. - modinfo like tool (but i think it would require source or descriptions compiled in kernel)
Domen - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |