Messages in this thread | | | Date | Sun, 6 Feb 2005 20:47:53 +0100 | From | Vojtech Pavlik <> | Subject | Re: [PATCH] remove pointless <0 comparisons for unsigned vars, and avoid a few signed vs unsigned comparisons in drivers/char/keyboard.c |
| |
On Mon, Nov 22, 2004 at 12:21:55AM +0100, Jesper Juhl wrote: > > Hi, > > Sorry about the possibly irrelevant CC list, but I couldn't find a > maintainer for drivers/char/keyboard.c listed anywhere, so I ended up > sending to lkml and CC'ing a few people who has worked on the file, and > akpm as a fallback person due to his 2.6 maintainer role. > > Here's a patch that removes a few pointless comparisons; "scancode" is > unsigned so it can never be <0 which makes the test pointless. > Also, there are a few instances where signed and unsigned variables are > comared, and as far as I can tell they really should just all be unsigned. > > Comments welcome (I must confess that I've only compile tested this so > far). > > Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
Looks sane: Applied.
-- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |