Messages in this thread | | | Date | Fri, 04 Feb 2005 12:45:35 +0000 | From | Paulo Marques <> | Subject | Re: [uml-devel] Re: [PATCH 2.6] 4/7 replace uml_strdup by kstrdup |
| |
Blaisorblade wrote: >[...] > For UML, you should probably add the prototype to a good header inside > arch/um/include (those headers are in the searchpath for every file under > arch/um) - probably the one which declared uml_strdup. Yes, we have had to > duplicate prototypes for many functions... for inlines, we've had to provide > in many case a non-inline version.
Thanks for the tip. I'll have to read the code more carefully to understand better where the userspace ends and the kernel begins, so that I don't do similar mistakes in the future.
I'll redo the patch and post it for review, probably during next week. I don't think there is much hurry, because, even if this gets accepted, it should go in only in 2.6.12-rc1-mm1 or something like that, so there is still time to review this more carefully.
Thanks for reviewing the patch,
-- Paulo Marques - www.grupopie.com
All that is necessary for the triumph of evil is that good men do nothing. Edmund Burke (1729 - 1797) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |