Messages in this thread | | | Date | Fri, 4 Feb 2005 09:17:33 -0500 | From | Dmitry Torokhov <> | Subject | Re: [PATCH 2.6.11-rc3] IBM Trackpoint support |
| |
On Fri, 4 Feb 2005 07:54:54 +0100, Vojtech Pavlik <vojtech@suse.cz> wrote: > On Fri, Feb 04, 2005 at 01:52:39AM -0500, Dmitry Torokhov wrote: > > On Friday 04 February 2005 01:35, Vojtech Pavlik wrote: > > > On Thu, Feb 03, 2005 at 07:34:16PM -0500, Dmitry Torokhov wrote: > > > > On Thursday 03 February 2005 17:43, Stephen Evanchik wrote: > > > > > Vojtech, > > > > > > > > > > Here is a patch that exposes the IBM TrackPoint's extended properties > > > > > as well as scroll wheel emulation. > > > > > > > > > > > > > > > > > > Hi, > > > > > > > > Very nice although I have a couple of comments. > > > > > > > > > /* > > > > > + * Try to initialize the IBM TrackPoint > > > > > + */ > > > > > + if (max_proto > PSMOUSE_PS2 && trackpoint_init(psmouse) == 0) { > > > > > + psmouse->vendor = "IBM"; > > > > > + psmouse->name = "TrackPoint"; > > > > > + > > > > > + return PSMOUSE_PS2; > > > > > > > > Why PSMOUSE_PS2? Reconnect will surely not like it. > > > > > > Indeed. IIRC this patch killed wheel mouse detection in ubuntu. > > > > > > > We may need yet another psmouse_reset after unsuccessful test. > > We probably should do one after every test for isolation. It's not that > big a problem now that we do the probing from a thread. >
It is still a problem if driver is registered after the port has been detected wich quite often is the case as many people have psmouse as a module.
I wonder if we should make driver registration asynchronous too. I don't forsee any issues providing that I bump up module's reference count while driver structure is "in flight", do you?
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |