Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE | Date | Sun, 27 Feb 2005 17:31:29 +0100 |
| |
On Sunday 27 February 2005 08:36, Tejun Heo wrote: > Hello, Bartlomiej. > > This patch should be modified to use flagged taskfile if the > task_end_request_fix patch isn't applied. As non-flagged taskfile > won't return valid result registers, TASK ioctl users won't get the > correct register output.
Nope, it works just fine because REQ_DRIVE_TASK used only no-data protocol, please check task_no_data_intr().
> IMHO, this flag-to-get-result-registers thing is way too subtle. How > about keeping old behavior by just not copying out register outputs in > ide_taskfile_ioctl() in applicable cases instead of not reading > registers when ending commands? That is, unless there's some > noticeable performance impacts I'm not aware of.
This would miss whole point of not _reading_ these registers (IO is slow). IMHO new flags denoting {in,out} registers should be added (to <linux/ata.h> to share them with libata) so new code can be sane and old flags would map on new flags when needed. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |