Messages in this thread | | | From | David Brownell <> | Subject | Re: [linux-usb-devel] [2.6 patch] drivers/usb/gadget/config.c: make a function static | Date | Mon, 28 Feb 2005 17:02:48 -0800 |
| |
On Monday 28 February 2005 4:34 pm, Adrian Bunk wrote: > This patch makes a needlessly global function static.
You sent this before, and time hasn't improved it. This function is exported to support composite (multi-function) devices, which need to assemble config descriptors in chunks (config + N* function) instead of all-at-once (config + single function).
> Signed-off-by: Adrian Bunk <bunk@stusta.de> > > --- > > drivers/usb/gadget/config.c | 2 +- > include/linux/usb_gadget.h | 6 ------ > 2 files changed, 1 insertion(+), 7 deletions(-) > > --- linux-2.6.11-rc4-mm1-full/include/linux/usb_gadget.h.old 2005-02-28 23:15:09.000000000 +0100 > +++ linux-2.6.11-rc4-mm1-full/include/linux/usb_gadget.h 2005-02-28 23:15:24.000000000 +0100 > @@ -854,12 +854,6 @@ > > /*-------------------------------------------------------------------------*/ > > -/* utility to simplify managing config descriptors */ > - > -/* write vector of descriptors into buffer */ > -int usb_descriptor_fillbuf(void *, unsigned, > - const struct usb_descriptor_header **); > - > /* build config descriptor from single descriptor vector */ > int usb_gadget_config_buf(const struct usb_config_descriptor *config, > void *buf, unsigned buflen, const struct usb_descriptor_header **desc); > --- linux-2.6.11-rc4-mm1-full/drivers/usb/gadget/config.c.old 2005-02-28 23:15:34.000000000 +0100 > +++ linux-2.6.11-rc4-mm1-full/drivers/usb/gadget/config.c 2005-02-28 23:15:49.000000000 +0100 > @@ -39,7 +39,7 @@ > * as part of configuring a composite device; or in other cases where > * sets of descriptors need to be marshaled. > */ > -int > +static int > usb_descriptor_fillbuf(void *buf, unsigned buflen, > const struct usb_descriptor_header **src) > { > > > > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |