lkml.org 
[lkml]   [2005]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] partitions/msdos.c


On Sun, 27 Feb 2005, Uwe Bonnes wrote:
>
> /dev/sda4 3512348 6003585 698791990+ 0 Empty
> Partition 4 has different physical/logical beginnings (non-Linux?):
> phys=(0, 0, 0) logical=(3512347, 6, 16)
> Partition 4 has different physical/logical endings:
> phys=(0, 0, 0) logical=(6003584, 7, 6)
> Partition 4 does not end on cylinder boundary.

Yeah, your case could check for zero in the physical sector stuff too, but
I'm not sure that matters, since nobody really cares about the physical
values and they've long been too limited to matter. So I'm not at all
convinced that adding a few more checks for zero would be any better than
checking the one zero that Andries does.

I think Andries' patch is fine. We should probably do the same for the
extended partition case, just to be consistent.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:1.128 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site