lkml.org 
[lkml]   [2005]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Linux-fbdev-devel] Re: 2.6.11-rc5
    Linus Torvalds wrote:
    >
    > On Sat, 26 Feb 2005, Olaf Hering wrote:
    >
    >>modedb can not be __init because fb_find_mode() may get db == NULL.
    >>fb_find_mode() is called from modules.
    >
    >
    > Ack. Maybe somebody should run the scripts again to check that we don't
    > reference __init data from non-init functions.
    >
    > Linus
    >
    This patch has already been posted to linux-fbdev on 2005-02-10 by David Vrabel
    and made me ask
    Is there any reason why this has been originally flagged "__init"?
    "vesa_modes" is not "__init". That's why I changed "intelfb" to
    use "vesa_modes".

    Maybe time has come to decide, if availability of "modedb" outside
    of init functions is more important than freeing (unused) kernel memory.

    --Axel






    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:10    [W:3.757 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site