lkml.org 
[lkml]   [2005]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] drivers/net/ne3210.c: cleanups
On Mon, Feb 21, 2005 at 03:39:54PM -0500, Jeff Garzik wrote:
> Adrian Bunk wrote:
> >@@ -197,7 +194,7 @@
> > ei_status.priv = phys_mem;
> >
> > if (ei_debug > 0)
> >- printk(version);
> >+ printk("ne3210 driver");
>
>
> missing newline. Do something like "ns3210 __DATE__ loaded.\n"
>
> Ditto for seeq8002.

Sorry for the missing newline.

I have to admit I still don't see why these printk's have to stay:
In both files, there are other printk's nearby that print the name of
the driver.

__DATE__ doesn't provide any information that wasn't already available
in the first line of the dmesg output.

> Jeff

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:10    [W:0.079 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site