Messages in this thread | | | Date | Thu, 24 Feb 2005 22:22:23 +0100 | From | Herbert Poetzl <> | Subject | Re: [Patch 4/6] Bind Mount Extensions 0.06 |
| |
On Wed, Feb 23, 2005 at 01:29:30AM +0100, Ingo Oeser wrote: > Hi, > > Herbert Poetzl wrote: > > +static inline int mnt_may_unlink(struct vfsmount *mnt, struct inode *dir, > > struct dentry *child) { + if (!child->d_inode) > > + return -ENOENT; > > + if (MNT_IS_RDONLY(mnt)) > > + return -EROFS; > > + return 0; > > +} > > The argument "dir" is not used. Please remove it and fix the callers.
hmm, yes, just saw that the mnt_may*() functions are not according to the 'current' coding style for that section/file, so I'll rework that anyway ...
thanks a lot for the input, Herbert
> Regards > > Ingo Oeser > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |