Messages in this thread | | | Date | Thu, 24 Feb 2005 09:32:54 -0800 | From | Greg KH <> | Subject | Re: [PATCH] CKRM [1/8] Base CKRM events, mods to existing kernel code |
| |
On Thu, Feb 24, 2005 at 01:33:53AM -0800, Gerrit Huizenga wrote: > Core CKRM Event Callbacks.
I could wait 3 months with my comments like you did with your reply, but I think I'll be a bit more timely, as I hope that you will be next time.
> On exec, fork, exit, real/effective gid/uid, use CKRM to associate > tasks with appropriate class. > > Addressed review comments: > > Sam Ravnborg: Use Makefile syntax correctly > Dave Hansen: Use of ## is annoying > Greg KH: Remove Changelogs; > Use __KERNEL__ correctly (if at all); > Consolidate CONFIG_ sections in header files; > Fix extern int get_exe_path_name(). > Remove unused DEBUG code > Convert enum to typedef in prep for sparce __bitwise use > > Not yet Addressed: > > Greg KH: > Use of __bitwise and sparse in enum's > Use of kernel list type
You forgot: Fix coding style Fix mix of whitespace (tabs and spaces)
Which you said you fixed up, but according to the code, you didn't :(
Also please add: Use kref instead of atomic counters Address Greg's comments about the fs.
I'll wait for these things to all get fixed up before reviewing the code again.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |