Messages in this thread | | | Subject | Re: [PATCH] CKRM [7/8] Resource controller for number of tasks per class | From | Dave Hansen <> | Date | Thu, 24 Feb 2005 08:15:43 -0800 |
| |
On Thu, 2005-02-24 at 01:34 -0800, Gerrit Huizenga wrote: > This patch provides a resource controller for limiting the number > of tasks per class in CKRM.
It takes 627 lines of code to count the number of tasks in a class? What does all of that infrastructure buy you, again?
All of the logic to borrow if you've gone over your limit should be a quite repeated theme throughout all of the controllers. Seems to me that at least a larger chunk of that should be in generic code.
> +static void numtasks_res_free(void *my_res) > +{ ... > + if (unlikely(atomic_read(&res->cnt_cur_alloc) < 0)) { > + printk(KERN_WARNING "numtasks_res: counter below 0 > \n"); > + } > + if (unlikely(atomic_read(&res->cnt_cur_alloc) > 0 || > + atomic_read(&res->cnt_borrowed) > 0))
How often is this called? Do you really need unlikely()?
-- Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |