lkml.org 
[lkml]   [2005]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] ppc32: kernel mapping breakage
    From
    Date
    Hi !

    Christoph Lameter's patch that change page allocators to use GFP_ZERO
    broke ppc32 in a subtle way. Our allocator is designed to work before
    mem_init_done, in which cases it uses a ppc specific early_get_page()
    which doesn't return zeroed pages. However, he removed the call to
    clear_page() unconditionally, thus causing the kernel initial page
    tables to have random data in them.

    They are initialized with set_pte, which means it's _mostly_ harmless,
    except that set_pte on ppc32 preserves the _PAGE_HASHPTE bit, thus we
    end up with random bits there, which can cause issues with further
    manipulation of the kernel page tables and will slow down all hash
    faults to them causing unnecessary searches.

    Please apply in 2.6.11 if still possible ...

    Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

    Index: linux-work/arch/ppc/mm/pgtable.c
    ===================================================================
    --- linux-work.orig/arch/ppc/mm/pgtable.c 2005-01-24 17:09:23.000000000 +1100
    +++ linux-work/arch/ppc/mm/pgtable.c 2005-02-23 14:31:41.000000000 +1100
    @@ -107,8 +107,11 @@
    ptepage->mapping = (void *) mm;
    ptepage->index = address & PMD_MASK;
    }
    - } else
    + } else {
    pte = (pte_t *)early_get_page();
    + if (pte)
    + clear_page(pte);
    + }
    return pte;
    }


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:10    [W:0.038 / U:1.272 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site