lkml.org 
[lkml]   [2005]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Memory leak in 2.6.11-rc1?
Date
I applied the patch and it works like a charm. As a kinky side effect: before 
this patch, using a compiled-in vesa or vga16 framebuffer worked with the
proprietary nvidia driver, whereas now tty1-6 are corrupt when not using
80x25. Strangeness :)

Lennert

On Monday 24 January 2005 23:35, Linus Torvalds wrote:
> On Mon, 24 Jan 2005, Andrew Morton wrote:
> > Would indicate that the new pipe code is leaking.
>
> Duh. It's the pipe merging.
>
> Linus
>
> ----
> --- 1.40/fs/pipe.c 2005-01-15 12:01:16 -08:00
> +++ edited/fs/pipe.c 2005-01-24 14:35:09 -08:00
> @@ -630,13 +630,13 @@
> struct pipe_inode_info *info = inode->i_pipe;
>
> inode->i_pipe = NULL;
> - if (info->tmp_page)
> - __free_page(info->tmp_page);
> for (i = 0; i < PIPE_BUFFERS; i++) {
> struct pipe_buffer *buf = info->bufs + i;
> if (buf->ops)
> buf->ops->release(info, buf);
> }
> + if (info->tmp_page)
> + __free_page(info->tmp_page);
> kfree(info);
> }
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-03-22 14:10    [W:0.646 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site