Messages in this thread | | | Date | Fri, 18 Feb 2005 12:24:09 +0100 | From | Pavel Machek <> | Subject | Re: Swsusp, resume and kernel versions |
| |
Hi!
> > > > Just remember you're doing the mkswap if you decide to rearrange your > > > > partitions at all, or code a script smart enough to grep your swap > > > > partitions out of your fstab. > > > > > > It could be a workaround. Still it will cause loss of unsaved work if > > > I happen to load wrong kernel. Given that the code checking for swsusp > > > image can be marked __init I don't understand the reasons gainst doing > > > it. > > > > How do you know which partitions to check? swsusp gets it from resume= parameter, > > but if you do not have it compiled, you probably have wrong cmdline, too. > > In many cases, you might have added the resume= line to every kernel > that's booted (eg, LILO's global append= parameter, or Debian GRUB's > magic kopts gear). Alternately (or additionally), you could examine > the signature when sys_swapon is called on a swap partition (though > the code couldn't be __init then). > > These together I want to claim would catch many of these cases, and > any effort to avoid severe filesystem corruption is a good thing.
Messing up the kernel to avoid fs corruption in some cases is bad idea.
If you want to be 100% safe, add support to LILO/GRUB: just do not allow selecting wrong kernel if last action was suspend. Bootloader knows, it seen the command lines.
Or simply use Stefan's userland code. Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |