Messages in this thread | | | Date | Fri, 18 Feb 2005 19:46:28 +0000 | From | Christoph Hellwig <> | Subject | Re: cciss CSMI via sysfs for 2.6 |
| |
> /* > + * sysfs stuff > + * this should be moved to it's own file, maybe cciss_sysfs.h > + */ > + > +static ssize_t cciss_firmver_show(struct device *dev, char *buf) > +{ > + ctlr_info_t *h = dev->driver_data; > + return sprintf(buf,"%c%c%c%c\n", h->firm_ver[0], h->firm_ver[1], > + h->firm_ver[2], h->firm_ver[3]); > +}
I really wish we had a common firmver release attribut in the driver core, as mentioned in the fc transport class thread. Greg?
> +static ssize_t cciss_bus_id_show(struct device *dev, char *buf) > +{ > + return sprintf(buf,"%s\n", dev->bus_id); > +}
this one is already exposed in the name of the sysfs link, see bus_add_device()
> + return sprintf(buf, "%x %x %x %x%x%x%x%x%x%x%x %x%x%x%x%x%x%x%x " > + "%x %x %x%x%x%x%x%x\n", > + p.bDeviceType, p.bRestricted, p.bInitiatorPortProtocol, > + p.bRestricted2[0], > + p.bRestricted2[1], > + p.bRestricted2[2], > + p.bRestricted2[3], > + p.bRestricted2[4], > + p.bRestricted2[5], > + p.bRestricted2[6], > + p.bRestricted2[7], > + p.bSASAddress[0], > + p.bSASAddress[1], > + p.bSASAddress[2], > + p.bSASAddress[3], > + p.bSASAddress[4], > + p.bSASAddress[5], > + p.bSASAddress[6], > + p.bSASAddress[7], > + p.bPhyIdentifier, p.bSignalClass, > + p.bReserved[0], > + p.bReserved[1], > + p.bReserved[2], > + p.bReserved[3], > + p.bReserved[4], > + p.bReserved[5]); > +}
This belongs into a SAS/SATA phy transport class and should be split into multiple attributes.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |