Messages in this thread | | | Date | Thu, 17 Feb 2005 20:10:30 +0100 | From | Adrian Bunk <> | Subject | Re: [2.6 patch] kill include/linux/eeprom.h |
| |
On Thu, Feb 17, 2005 at 01:36:09PM -0500, Jeff Garzik wrote: > Adrian Bunk wrote: > >This patch kills include/linux/eeprom.h . > > > >Rationale: > >- it's only used by one single driver > >- most of this file are non-inline and non-static functions (sic) > > > >This patch moves all required contents of this file into ns83820.c and > >removes include/linux/eeprom.h (and makes setup_ee_mem_bitbanger > >static). > > > >Signed-off-by: Adrian Bunk <bunk@stusta.de> > > I would rather update other drivers to use it :)
You mean you want to: - move the code from the header file to a .c file - implement the write method that is currently empty - add uses of the eeprom code (note that even ns83820.c used only one of the 7 functions in eeprom.h).
Noone did any of these during the more than 3 years eeprom.h already exists...
> Jeff
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |