lkml.org 
[lkml]   [2005]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH, new ACPI driver] new sony_acpi driver
    On Fri, 11 Feb 2005 12:36:37 +0100, Stelian Pop <stelian@popies.net> wrote:
    > +static int __init sony_acpi_add(struct acpi_device *device)
    > +{
    > + acpi_status status = AE_OK;
    > + struct sony_snc *snc = NULL;
    > + int result;
    > +
    > + snc = kmalloc(sizeof(struct sony_snc), GFP_KERNEL);
    > + if (!snc)
    > + return -ENOMEM;
    > + memset(snc, 0, sizeof(struct sony_snc));

    Nitpick: use kcalloc() instead of kmalloc() and memset().

    Pekka
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:10    [W:4.126 / U:0.692 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site