lkml.org 
[lkml]   [2005]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateFri, 11 Feb 2005 17:31:43 +0000
FromChristoph Hellwig <>
SubjectRe: [PATCH] device-mapper: multipath
> +#include "dm.h"
> +#include "dm-path-selector.h"
> +#include "dm-bio-list.h"
> +#include "dm-bio-record.h"
> +
> +#include <linux/ctype.h>
> +#include <linux/init.h>
> +#include <linux/mempool.h>
> +#include <linux/module.h>
> +#include <linux/pagemap.h>
> +#include <linux/slab.h>
> +#include <linux/time.h>
> +#include <linux/workqueue.h>
> +#include <asm/atomic.h>

Always include private headers after public ones.

> +MODULE_DESCRIPTION(DM_NAME " multipath target");
> +MODULE_AUTHOR("Sistina Software <dm-devel@redhat.com>");

Isn't this Red Hat now?

> +#ifndef DM_MPATH_H
> +#define DM_MPATH_H
> +
> +#include <linux/device-mapper.h>

no needed, a forward-declaration for struct dm_dev is enough.

> +EXPORT_SYMBOL(dm_register_path_selector);
> +EXPORT_SYMBOL(dm_unregister_path_selector);

I though we agreed to only allow GPL'ed path selectors at OSDL?

> +#ifndef DM_PATH_SELECTOR_H
> +#define DM_PATH_SELECTOR_H
> +
> +#include <linux/device-mapper.h>

again, doesn't look like it's needed.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:10    [from the cache]
©2003-2010