Messages in this thread Patch in this message | | | From | Jesper Juhl <> | Subject | [PATCH] Decrease number of pointer derefs in nf_conntrack_core.c | Date | Thu, 8 Dec 2005 23:36:19 +0100 |
| |
Hi,
Here's a small patch to decrease the number of pointer derefs in net/netfilter/nf_conntrack_core.c
Benefits of the patch: - Fewer pointer dereferences should make the code slightly faster. - Size of generated code is smaller - improved readability
Please consider applying.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> ---
net/netfilter/nf_conntrack_core.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
orig: text data bss dec hex filename 12636 49 760 13445 3485 net/netfilter/nf_conntrack_core.o
patched: text data bss dec hex filename 11825 183 632 12640 3160 net/netfilter/nf_conntrack_core.o
--- linux-2.6.15-rc5-git1-orig/net/netfilter/nf_conntrack_core.c 2005-12-04 18:48:58.000000000 +0100 +++ linux-2.6.15-rc5-git1/net/netfilter/nf_conntrack_core.c 2005-12-08 20:13:03.000000000 +0100 @@ -1129,6 +1129,7 @@ static inline int refresh_timer(struct n int nf_conntrack_expect_related(struct nf_conntrack_expect *expect) { struct nf_conntrack_expect *i; + struct nf_conn *master = expect->master; int ret; DEBUGP("nf_conntrack_expect_related %p\n", related_to); @@ -1149,9 +1150,9 @@ int nf_conntrack_expect_related(struct n } } /* Will be over limit? */ - if (expect->master->helper->max_expected && - expect->master->expecting >= expect->master->helper->max_expected) - evict_oldest_expect(expect->master); + if (master->helper->max_expected && + master->expecting >= master->helper->max_expected) + evict_oldest_expect(master); nf_conntrack_expect_insert(expect); nf_conntrack_expect_event(IPEXP_NEW, expect);
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |