Messages in this thread | | | Date | Tue, 6 Dec 2005 22:20:02 +0000 | From | Matthew Garrett <> | Subject | Re: [RFC]add ACPI hooks for IDE suspend/resume |
| |
On Tue, Dec 06, 2005 at 02:10:04PM +0800, Shaohua Li wrote:
> TODO: invoking ATA commands. > > Though we didn't invoke ATA commands, this patch fixes the bug at > http://bugzilla.kernel.org/show_bug.cgi?id=5604. And Matthew said this > actually fixes a lot of systems in his test. > I'm not familiar with IDE, so comments/suggestions are welcome.
Of the DSDTs I've looked at, most seem to provide taskfile commands concerned about doing things like setting up drive security. I haven't yet seen an IDE failure on resume when using this patch, so the _GTF stuff doesn't seem terribly important. The reason for it not currently being implemented is that the IDE queues haven't been restarted at the point where this code is called, so there's no obvious way of submitting them to the drive yet.
-- Matthew Garrett | mjg59@srcf.ucam.org - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |