Messages in this thread | | | Date | Tue, 06 Dec 2005 16:48:12 +1100 | From | Nick Piggin <> | Subject | Re: [RFC] lockless radix tree readside |
| |
David S. Miller wrote: > From: Nick Piggin <nickpiggin@yahoo.com.au> > Date: Tue, 06 Dec 2005 12:40:56 +1100 > > >>I realise that radix-tree.c isn't a trivial bit of code so I don't >>expect reviews to be forthcoming, but if anyone had some spare time >>to glance over it that would be great. > > > I went over this a few times and didn't find any obvious > problems with the RCU aspect of this. >
Thanks!
> >>Is my given detail of the implementation clear? Sufficient? Would >>diagrams be helpful? > > > If I were to suggest an ascii diagram for a comment, it would be > one which would show the height invariant this patch takes advantage > of. >
I'll see if I can make something reasonably descriptive. And possibly another diagram to show the node insertion concurrency cases vs lookup. These things are the main concepts to understand, so I agree diagrams might be helpful.
Nick
-- SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |