Messages in this thread Patch in this message |  | | | Date | Mon, 5 Dec 2005 16:28:49 +0530 | | From | Srivatsa Vaddagiri <> | | Subject | [PATCH] Fix bug in RCU torture test |
While doing some test of RCU torture module, I hit a OOPS in rcu_do_batch, which was trying to processes callback of a module that was just removed. This is because we weren't waiting long enough for all callbacks to fire.
Patch below fixes that.
Signed-off-by : Srivatsa Vaddagiri <vatsa@in.ibm.com>
--- linux-2.6.15-rc5-mm1-root/kernel/rcutorture.c | 3 +-- 1 files changed, 1 insertion(+), 2 deletions(-) diff -puN kernel/rcutorture.c~rcutorture_fix kernel/rcutorture.c --- linux-2.6.15-rc5-mm1/kernel/rcutorture.c~rcutorture_fix 2005-12-05 15:33:06.000000000 +0530 +++ linux-2.6.15-rc5-mm1-root/kernel/rcutorture.c 2005-12-05 15:33:17.000000000 +0530 @@ -408,9 +408,8 @@ rcu_torture_cleanup(void) stats_task = NULL; /* Wait for all RCU callbacks to fire. */ + rcu_barrier(); - for (i = 0; i < RCU_TORTURE_PIPE_LEN; i++) - synchronize_rcu(); rcu_torture_stats_print(); /* -After- the stats thread is stopped! */ printk(KERN_ALERT TORTURE_FLAG "--- End of test: %s\n", _
--
Thanks and Regards, Srivatsa Vaddagiri, Linux Technology Center, IBM Software Labs, Bangalore, INDIA - 560017 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |